[ https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715947#comment-15715947 ]
Jian He commented on YARN-5559: ------------------------------- [~ajisakaa], the patch looks good to me, only that I saw CopyOnWriteArrayList is used for NodeLabel list. This list will be returned to user code in the getNodeLabelList(), and it has some uncommon characteristics like certain operations on the iterator is not supported, I wonder whether it's better to return a usual list and synchronize these methods directly ? > Analyse 2.8.0/3.0.0 jdiff reports and fix any issues > ---------------------------------------------------- > > Key: YARN-5559 > URL: https://issues.apache.org/jira/browse/YARN-5559 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Wangda Tan > Assignee: Akira Ajisaka > Priority: Blocker > Labels: oct16-easy > Attachments: YARN-5559.1.patch, YARN-5559.2.patch, YARN-5559.3.patch, > YARN-5559.4.patch, YARN-5559.5.patch, YARN-5559.6.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org