[ 
https://issues.apache.org/jira/browse/YARN-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717006#comment-15717006
 ] 

Jian He commented on YARN-5961:
-------------------------------

looks good to me.  should below profile in the same pom file be removed ? 

{code}
    <profile>
      <id>compile-protobuf</id>
      <build>
        <plugins>
          <plugin>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-maven-plugins</artifactId>
            <executions>
              <execution>
                <id>compile-protoc</id>
                <phase>generate-sources</phase>
                <goals>
                  <goal>protoc</goal>
                </goals>
                <configuration>
                  <protocVersion>${protobuf.version}</protocVersion>
                  <protocCommand>protoc</protocCommand>
                  <imports>
                    <param>${basedir}/src/main/proto</param>
                  </imports>
                  <source>
                    <directory>${basedir}/src/main/proto</directory>
                    <includes>
                      <include>SliderClusterMessages.proto</include>
                      <include>SliderClusterProtocol.proto</include>
                    </includes>
                  </source>
                </configuration>
              </execution>
            </executions>
          </plugin>
        </plugins>
      </build>
    </profile>
{code}

> Generate native services protobuf classes during build
> ------------------------------------------------------
>
>                 Key: YARN-5961
>                 URL: https://issues.apache.org/jira/browse/YARN-5961
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: yarn-native-services
>
>         Attachments: YARN-5961-yarn-native-services.001.patch
>
>
> The generated Messages.java and SliderClusterAPI.java classes could be 
> removed if we generate them during the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to