[
https://issues.apache.org/jira/browse/YARN-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755543#comment-15755543
]
Billie Rinaldi commented on YARN-5967:
--------------------------------------
[~jianhe], this is looking great so far. Here are some specific comments. I
tried to point out places where it would be easy to fix an error rather than
ignoring the warning, but I also don't think any of these are a real problem.
* There is a non-generated class in the proto package. Maybe we should move
that to a different package?
* For SliderKeys COMPONENT_KEYS_TO_SKIP, we could make it a List and use
Collections.unmodifiableList(Arrays.asList(…)) instead of ignoring
MS_MUTABLE_ARRAY.
* StringBuffer in AbstractActionArgs could be StringBuilder.
* We should specify Charset.forName("UTF-8”) or StandardCharsets.UTF_8 instead
of ignoring DM_DEFAULT_ENCODING, where possible. FileReader can be switched to
an InputStreamReader. PrintStream has a constructor which takes a File and a
charset name as a String. Not sure about PrintWriter.
* I am not sure we should ignore OS_OPEN_STREAM, but I did not look at the
individual cases of this error.
* In AppDefinitionPersister, let’s move File defPath = new File(value) after
the if (SliderUtils.isUnset(value)) check.
* Since OutstandingRequestTracker newerThan is Serializable now, does it need a
serialVersionUID?
* For OutstandingRequest, would it be better to have a trivial equals method
that calls super.equals instead of ignoring EQ_DOESNT_OVERRIDE_EQUALS?
* In RoleInstance, we could make output private instead of ignoring
UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD.
* In Probe, could we make bootstrapStarted and bootstrapFinished private
instead of ignoring URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD? I see there is a
comment saying to leave them alone, but maybe making them private isn’t what
the comment meant.
* In PublisherResource, I think we could make getAMClassPath return a List<URL>
rather than ignoring DMI_COLLECTION_OF_URLS.
* The ContainerStatsBlock error still needs to be handled, correct?
> Fix slider core module findbugs warnings
> -----------------------------------------
>
> Key: YARN-5967
> URL: https://issues.apache.org/jira/browse/YARN-5967
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-5967-yarn-native-services.01.patch,
> YARN-5967-yarn-native-services.02.patch,
> YARN-5967-yarn-native-services.02.patch,
> YARN-5967-yarn-native-services.03.patch,
> YARN-5967-yarn-native-services.04.patch,
> YARN-5967-yarn-native-services.04.patch,
> YARN-5967-yarn-native-services.05.patch,
> YARN-5967-yarn-native-services.06.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
