[
https://issues.apache.org/jira/browse/YARN-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Templeton resolved YARN-5992.
------------------------------------
Resolution: Duplicate
YARN-6000 already resolves the issue, even though this patch was posted first.
Sorry about that.
> revert the visibility of interface AllocationFileLoaderService.Listener to
> public for outside usage
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-5992
> URL: https://issues.apache.org/jira/browse/YARN-5992
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 3.0.0-alpha2
> Reporter: Pan Yuxuan
> Attachments: YARN-5992.patch
>
>
> The visibility of interface {{AllocationFileLoaderService.Listener}} is
> changed from public to default by YARN-4997.
> This may cause some downsteam like Hive with compile error:
> {noformat}
> Hive/src/shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java:[45,67]
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.Listener
> is not public in
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService;
> cannot be accessed from outside package
> {noformat}
> org/apache/hadoop/hive/schshim/FairSchedulerShim.java uses the interface like
> below:
> {noformat}
> allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() {
> @Override
> public void onReload(AllocationConfiguration allocs) {
> allocConf.set(allocs);
> }
> });
> {noformat}
> So can we revert the visibility of {{AllocationFileLoaderService.Listener}}
> to public so that the downstream can use the interface as before, otherwise,
> the downstream should make some changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
