[
https://issues.apache.org/jira/browse/YARN-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796563#comment-15796563
]
Wangda Tan commented on YARN-3955:
----------------------------------
Thanks [~sunilg], some additional comments:
1) Common logic of checkAccess / getDefaultPriority can be merged further: both
can get approvedPriority first.
2) As I commented above, do changes of capacity-scheduler.xml related to the
patch? I cannot find which module uses {{acl_access_priority}} in
configuration. If not, could you add correct default value?
3) CapacityScheduler:
- updateApplicationPriority should hold writeLock?
- similiarily, checkAndGetApplicationPriority should hold readlock?
- checkAndGetApplicationPriority: when an app's priority set to negative, I
think we should use 0 instead of max. Thoughts?
-
4) AppPriorityACLsMgr:
- addPrioirityACLs, should we do "replace" instead of "add" to acl groups? If
it is not intentional, could you add a test to make sure update of acls works?
(like change from \[1,2,3\] to \[1,3,4\])
- getPriorityPerUserACL -> getMappedPriorityAclForUGI.
5) As I mentioned before, remove readlock of LQ#getPriorityAcls, final should
be enough.
6) YarnScheduler: why the new added method has SettableFuture in parameters? It
doesn't look very clean ...
> Support for priority ACLs in CapacityScheduler
> ----------------------------------------------
>
> Key: YARN-3955
> URL: https://issues.apache.org/jira/browse/YARN-3955
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: ApplicationPriority-ACL.pdf,
> ApplicationPriority-ACLs-v2.pdf, YARN-3955.0001.patch, YARN-3955.0002.patch,
> YARN-3955.0003.patch, YARN-3955.0004.patch, YARN-3955.0005.patch,
> YARN-3955.0006.patch, YARN-3955.0007.patch, YARN-3955.v0.patch,
> YARN-3955.v1.patch, YARN-3955.wip1.patch
>
>
> Support will be added for User-level access permission to use different
> application-priorities. This is to avoid situations where all users try
> running max priority in the cluster and thus degrading the value of
> priorities.
> Access Control Lists can be set per priority level within each queue. Below
> is an example configuration that can be added in capacity scheduler
> configuration
> file for each Queue level.
> yarn.scheduler.capacity.root.<queue_name>.<priority>.acl=user1,user2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
