[
https://issues.apache.org/jira/browse/YARN-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796676#comment-15796676
]
Karthik Kambatla commented on YARN-6041:
----------------------------------------
Thanks for putting this up on JIRA, [~asuresh].
I skimmed through the patch, paying attention to compatibility and user-facing
configs. The patch looks mostly good.
# Assuming MRJobConfig. MR_NUM_OPPORTUNISTIC_MAPS_PER_100 was not part of any
release. Can you confirm the same?
# Should the corresponding methods in RMContainerAllocator be also renamed to
use percentage instead of per_100? Also, should the config name be PERCENT
instead of PERCENTAGE to be consistent with other configs in MR?
# Nit: For scheduler-related configs, should we use yarn.scheduler.* like other
scheduler configs? And, yarn.nodemanager.* for all node-specific opportunistic
container configs? Making sure the configs are consistent and simple is a good
exercise before we include these in a release.
# Assuming the incompatible proto changes to yarn_server_common_protos and
yarn_server_common_service_protos are okay because the previous versions didn't
make it to a release. Can you confirm the same?
> Opportunistic containers : Combined patch for branch-2
> -------------------------------------------------------
>
> Key: YARN-6041
> URL: https://issues.apache.org/jira/browse/YARN-6041
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-6041-branch-2.001.patch,
> YARN-6041-branch-2.002.patch
>
>
> This is a combined patch targeting branch-2 of the following JIRAs which have
> already been committed to trunk :
> YARN-5938. Refactoring OpportunisticContainerAllocator to use
> SchedulerRequestKey instead of Priority and other misc fixes
> YARN-5646. Add documentation and update config parameter names for scheduling
> of OPPORTUNISTIC containers.
> YARN-5982. Simplify opportunistic container parameters and metrics.
> YARN-5918. Handle Opportunistic scheduling allocate request failure when NM
> is lost.
> YARN-4597. Introduce ContainerScheduler and a SCHEDULED state to NodeManager
> container lifecycle.
> YARN-5823. Update NMTokens in case of requests with only opportunistic
> containers.
> YARN-5377. Fix
> TestQueuingContainerManager.testKillMultipleOpportunisticContainers.
> YARN-2995. Enhance UI to show cluster resource utilization of various
> container Execution types.
> YARN-5799. Fix Opportunistic Allocation to set the correct value of Node Http
> Address.
> YARN-5486. Update OpportunisticContainerAllocatorAMService::allocate method
> to handle OPPORTUNISTIC container requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
