[ 
https://issues.apache.org/jira/browse/YARN-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698232#comment-13698232
 ] 

Siddharth Seth commented on YARN-710:
-------------------------------------

In the unit test, the setters on the ApplicationId aren't meant to be used 
(will end up throwing exceptions - this is replaced by newInstance in 
AppliactionId). Don't think getProto() needs to be changed at all in 
RecordFactoryPBImpl - instead a new getBuilder method should be sufficient. 
Somewhere along the flow, it looks like the default proto ends up being created 
- possibly linked to the getProto changes.
                
> Add to ser/deser methods to RecordFactory
> -----------------------------------------
>
>                 Key: YARN-710
>                 URL: https://issues.apache.org/jira/browse/YARN-710
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: api
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: YARN-710.patch, YARN-710.patch, YARN-710-wip.patch
>
>
> I order to do things like AMs failover and checkpointing I need to serialize 
> app IDs, app attempt IDs, containers and/or IDs,  resource requests, etc.
> Because we are wrapping/hiding the PB implementation from the APIs, we are 
> hiding the built in PB ser/deser capabilities.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to