[ 
https://issues.apache.org/jira/browse/YARN-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824582#comment-15824582
 ] 

Shane Kumpf commented on YARN-5258:
-----------------------------------

Sorry for the very late response here. Overall, this looks great. Thanks 
[~templedf] for putting this together!

1)
{code}
When the LCE launches YARN a container to execute in a Docker container, the 
application can specify the Docker images to be used with that YARN container.
{code}
It seems removing the first occurrence of YARN would make this clearer, or 
consider shortening.

2)
{code}
In order to launch Docker containers, the Docker daemon be running on all 
NodeManager hosts where Docker containers will be launched.
{code}
"...the Docker daemon *must* be running..."

3) 
{code}
Note that the Java and Hadoop versions must be compatible with what’s installed 
on the cluster.
{code}
I'm not sure what this means exactly. Can you help clarify a bit in the docs?

4) Connecting to a Secure Docker Repository - Unfortunately, I don't believe 
the default of $HOME/.docker/config.json will work in the implicit pull 
scenario. It seems $HOME is not expanded in container-executor when running the 
Docker client commands. Given this, we should advise that it is necessary to 
pre-pull images from private registries and that implicit pulls from private 
registries are not supported without YARN-5428.

> Document Use of Docker with LinuxContainerExecutor
> --------------------------------------------------
>
>                 Key: YARN-5258
>                 URL: https://issues.apache.org/jira/browse/YARN-5258
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: documentation
>    Affects Versions: 2.8.0
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>              Labels: oct16-easy
>         Attachments: YARN-5258.001.patch, YARN-5258.002.patch, 
> YARN-5258.003.patch, YARN-5258.004.patch
>
>
> There aren't currently any docs that explain how to configure Docker and all 
> of its various options aside from reading all of the JIRAs.  We need to 
> document the configuration, use, and troubleshooting, along with helpful 
> examples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to