[
https://issues.apache.org/jira/browse/YARN-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827042#comment-15827042
]
Subru Krishnan commented on YARN-5966:
--------------------------------------
Thanks [~asuresh] for the patch. I looked at it and have a couple of comments:
* In the {{AMRMClientImpl}}, I feel it'll be simpler/cleaner if we validate
and fail fast if required based on the {{ContainerUpdateType}} enum instead of
the implicit auto-correction. It should also be very straightforward to have
corresponding coverage in tests.
* I have few _optional_ suggestions for
{{TestOpportunisticContainerAllocation}} - since you have done the
heavy-lifting of adding the harness code, you should consider adding tests for
idempotency checks (GUARANTEED --> GUARANTEED and OPPORTUNISTIC -->
OPPORTUNISTIC). We only have positive test cases, I feel promotion especially
need not necessarily be satisfied and so will be good to have tests covering
these rejection scenarios.
* A separate thought I had is how do we handle promotion/demotion requests
where the container has completed during the interim?
> AMRMClient changes to support ExecutionType update
> --------------------------------------------------
>
> Key: YARN-5966
> URL: https://issues.apache.org/jira/browse/YARN-5966
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5966.001.patch, YARN-5966.002.patch,
> YARN-5966.wip.001.patch
>
>
> {{AMRMClient}} changes to support change of container ExecutionType
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
