[ 
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700371#comment-13700371
 ] 

Bikas Saha commented on YARN-353:
---------------------------------

I dont think it makes sense to have default value for this. ZK location is not 
something we control and we cannot assume it to be running on some default 
location. The commented value in the default.xml file is just for a syntax 
example.
{code}
+  public static final String DEFAULT_ZK_RM_STATE_STORE_ADDRESS =
+      "127.0.0.1:2181";
{code}

Wherever we are doing multiple operations, we should probably use the ZK multi 
API's to guarantee atomic operations.
{code}
+        + latestSequenceNumber);
+    try {
+      if (dtSequenceNumberPath != null) {
+        deleteWithRetries(dtSequenceNumberPath, 0);
+      }
+      createWithRetries(latestSequenceNumberPath, null, zkAcl,
+        CreateMode.PERSISTENT);
+    } catch (Exception e) {
+      LOG.info("Error in storing " + dtSequenceNumberPath);
+      throw e;
+    }
+    dtSequenceNumberPath = latestSequenceNumberPath;
{code}


                
> Add Zookeeper-based store implementation for RMStateStore
> ---------------------------------------------------------
>
>                 Key: YARN-353
>                 URL: https://issues.apache.org/jira/browse/YARN-353
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Hitesh Shah
>            Assignee: Bikas Saha
>         Attachments: YARN-353.1.patch, YARN-353.2.patch, YARN-353.3.patch, 
> YARN-353.4.patch
>
>
> Add store that write RM state data to ZK

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to