[
https://issues.apache.org/jira/browse/YARN-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834293#comment-15834293
]
Naganarasimha G R commented on YARN-6109:
-----------------------------------------
Thanks [~xgong],
Overall approach looks fine, Few comments from my side
# Not sure what should be the behavior when there are any queue reservations
(PlanQueues)
# ParentQueue ln no 315, {{childQueue.getQueueName}} needs to be used else it
not remove properly. (findbugs is also for the same reason).
# ParentQueue ln no 325, comment can be updated to "Re-init existing queue"
# CapacitySchedulerQueueManager ln no 302, {{Convert}} -> {{Converting}}
# TestCapacityScheduler, ln no 478 : how about
{{setupQueueConfigurationWithB1toParentQueue}} =>
{{setupQueueConfigurationWithB1AsParentQueue}} ?
# TestCapacityScheduler, ln no 4014 : error message seems to be from
deleteQueue,
# test case failures might not be related to the patch but can you take a look
at the check style ?
> Add an ability to convert ChildQueue to ParentQueue
> ---------------------------------------------------
>
> Key: YARN-6109
> URL: https://issues.apache.org/jira/browse/YARN-6109
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6109.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
