[ 
https://issues.apache.org/jira/browse/YARN-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840183#comment-15840183
 ] 

Wangda Tan commented on YARN-6123:
----------------------------------

Thanks [~sunilg] for reviewing it, 

For 1. I think it is safe, since now assignmentIterator is called under CS's 
readlock, and reinitialize queue needs CS's writeLock.
For 2. Addressed.


> [YARN-5864] Add a test to make sure queues of orderingPolicy will be updated 
> when childQueues added or removed.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6123
>                 URL: https://issues.apache.org/jira/browse/YARN-6123
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-6123.001.patch, YARN-6123.002.patch
>
>
> YARN-5864 added queue ordering policy to ParentQueue, we need to make sure 
> queues of QueueOrderingPolicy will be updated when any changes made for child 
> queues.
> We need to add a test to make sure it works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to