[ 
https://issues.apache.org/jira/browse/YARN-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847766#comment-15847766
 ] 

Xuan Gong commented on YARN-6100:
---------------------------------

Thanks for the review. [~djp]
bq.  I think that could be helpful for trouble shooting. Isn't it? Also, do we 
need to close os which output stream? I haven't check if caller have similar 
logic. If we already have, we can skip here.

Yes, we have close it in client side. We do not need to do it on server side.

Uploaded patches for trunk and branch-2 for other comments

> improve YARN webservice to output aggregated container logs
> -----------------------------------------------------------
>
>                 Key: YARN-6100
>                 URL: https://issues.apache.org/jira/browse/YARN-6100
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-6100.1.patch, YARN-6100.2.patch, 
> YARN-6100.branch-2.v1.patch, YARN-6100.branch-2.v3.patch, 
> YARN-6100.branch-2.v4.patch, YARN-6100.trunk.2.patch, 
> YARN-6100.trunk.v1.patch, YARN-6100.trunk.v3.patch, YARN-6100.trunk.v4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to