[ https://issues.apache.org/jira/browse/YARN-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848631#comment-15848631 ]
ASF GitHub Bot commented on YARN-6061: -------------------------------------- Github user kambatla commented on a diff in the pull request: https://github.com/apache/hadoop/pull/182#discussion_r98942179 --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java --- @@ -824,25 +824,29 @@ public void handle(RMFatalEvent event) { * Transition to standby in a new thread. */ public void handleTransitionToStandByInNewThread() { - new Thread() { - @Override - public void run() { - if (rmContext.isHAEnabled()) { - try { - // Transition to standby and reinit active services - LOG.info("Transitioning RM to Standby mode"); - transitionToStandby(true); - EmbeddedElector elector = rmContext.getLeaderElectorService(); - if (elector != null) { - elector.rejoinElection(); - } - } catch (Exception e) { - LOG.fatal("Failed to transition RM to Standby mode.", e); - ExitUtil.terminate(1, e); + Thread standByTransitionThread = new Thread(new StandByTransitionThread()); --- End diff -- Also, would it make sense to create an instance of the Runnable on transition to active, and start a new thread on a need-to basis. If all threads use a single instance of the Runnable, may be it is easier to coordinate? > Add a customized uncaughtexceptionhandler for critical threads in RM > -------------------------------------------------------------------- > > Key: YARN-6061 > URL: https://issues.apache.org/jira/browse/YARN-6061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6061.001.patch, YARN-6061.002.patch, > YARN-6061.003.patch, YARN-6061.004.patch, YARN-6061.005.patch > > > There are several threads in fair scheduler. The thread will quit when there > is a runtime exception inside it. We should bring down the RM when that > happens. Otherwise, there may be some weird behavior in RM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org