[ https://issues.apache.org/jira/browse/YARN-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853216#comment-15853216 ]
Manikandan R commented on YARN-5703: ------------------------------------ Thanks [~Naganarasimha] for review. I've attached newer patch based on comments and given explanation for each one below. * Ok, I used {code} agentclass = Configuration.getClass(String, Class<? extends U>, Class<U>) {code} to create objects. * I've defined few constants in {code}ReservationSchedulerConfiguration{code}. To access those values through its corresponding getters method in {code}init(ReservationSchedulerConfiguration conf) {code} of AlignedPlannerWithGreedy & GreedyReservationAgent classes, I've defined the method {code} void init(ReservationSchedulerConfiguration conf); {code} in ReservationAgent.java. If I don't specify right sub class, those constants and its getters won't be available? Do you see any issues here? * Yes, configurable doesn't suit here. But, {code}init(ReservationSchedulerConfiguration conf){code} has been implemented already. * Yes, {code}yarnConf{code} doesn't add value here. The reason for including {code} init(ReservationSchedulerConfiguration conf) {code} in IterativePlanner.java is, it extends {code}PlanningAlgorithm{code}, which again has implemented {code}ReservationAgent{code}. Since configuration is available in AlignedPlannerWithGreedy & GreedyReservationAgent classes, thought of passing the same to IterativePlanner.java & TryManyReservationAgents.java as both classes has implemented {code}ReservationAgent{code} interface, but there is no use of it currently. > ReservationAgents are not correctly configured > ---------------------------------------------- > > Key: YARN-5703 > URL: https://issues.apache.org/jira/browse/YARN-5703 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, resourcemanager > Affects Versions: 3.0.0-alpha1 > Reporter: Sean Po > Assignee: Manikandan R > Attachments: YARN-5703.001.patch, YARN-5703.002.patch, > YARN-5703.003.patch > > > In AbstractReservationSystem, the method that instantiates a ReservationAgent > does not properly initialize it with the appropriate configuration because it > expects the ReservationAgent to implement Configurable. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org