[
https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864464#comment-15864464
]
Varun Saxena commented on YARN-4675:
------------------------------------
Thanks Naga for the patch! A few more minor comments in addition to above.
# Nit : Changes in AMRMClientImpl are not required.
# Not very important but similar to point 4 in my earlier set of comments,
there are still a few more places where we can probably check for
YarnConfiguration#getTimelineServiceVersion == 2 instead of
YarnConfiguraiton#timelineServiceV2Enabled which checks for timeline service
enabled again. A couple of such places are JobHistoryEventHandler and
ApplicationMaster classes.
> Reorganize TimelineClient and TimelineClientImpl into separate classes for
> ATSv1.x and ATSv2
> --------------------------------------------------------------------------------------------
>
> Key: YARN-4675
> URL: https://issues.apache.org/jira/browse/YARN-4675
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: YARN-5355, yarn-5355-merge-blocker
> Attachments: YARN-4675.v2.002.patch, YARN-4675.v2.003.patch,
> YARN-4675.v2.004.patch, YARN-4675.v2.005.patch, YARN-4675.v2.006.patch,
> YARN-4675.v2.007.patch, YARN-4675.v2.008.patch,
> YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,
> TimeClientV2Impl and if required a base class, so that its clear which part
> of the code belongs to which version and thus better maintainable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
