[ 
https://issues.apache.org/jira/browse/YARN-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873303#comment-15873303
 ] 

Hitesh Sharma commented on YARN-6059:
-------------------------------------

[~kkaranasos], thank you for the great feedback.

The updated patch resolves the issues you brought up. I'm not sure why those 
stylecheck issues are coming because things look ok to me. I will look at it 
again later.

One thing that I'm not clear about is how to interpret or understand the 
loadContainerState method in NMLevelDbStateStoreService. Can you elaborate what 
the if conditions look for because they are very confusing.

I understand the part about suffixes not being removed, but what does the check 
on rcsStatus do.

 else if (suffix.equals(CONTAINER_QUEUED_KEY_SUFFIX)) {
        if (rcs.status == RecoveredContainerStatus.REQUESTED) {
          rcs.status = RecoveredContainerStatus.QUEUED;
        }
      } 

> Update paused container state in the state store
> ------------------------------------------------
>
>                 Key: YARN-6059
>                 URL: https://issues.apache.org/jira/browse/YARN-6059
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Hitesh Sharma
>            Assignee: Hitesh Sharma
>         Attachments: YARN-5216-YARN-6059.001.patch, 
> YARN-6059-YARN-5972.001.patch, YARN-6059-YARN-5972.002.patch, 
> YARN-6059-YARN-5972.003.patch, YARN-6059-YARN-5972.004.patch, 
> YARN-6059-YARN-5972.005.patch, YARN-6059-YARN-5972.006.patch, 
> YARN-6059-YARN-5972.007.patch, YARN-6059-YARN-5972.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to