[ 
https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879472#comment-15879472
 ] 

Karthik Kambatla commented on YARN-6210:
----------------------------------------

I like what we have better. It is clearer; nested ifs are more confusing 
because one has to hold the conditions of the previous if in context. Also, I 
don't see it being more efficient or anything either.

Since you are +1 either way, I ll go ahead and commit this. 

> FS: Node reservations can interfere with preemption
> ---------------------------------------------------
>
>                 Key: YARN-6210
>                 URL: https://issues.apache.org/jira/browse/YARN-6210
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: YARN-6210.1.patch, YARN-6210.2.patch, YARN-6210.3.patch, 
> YARN-6210.4.patch
>
>
> Today, on a saturated cluster, apps with pending demand reserve nodes. A new 
> app might not be able to preempt resources because these nodes are already 
> reserved. This can be reproduced by the example in YARN-6151. 
> Since node reservations are to prevent starvation of apps requesting large 
> containers, triggering these reservations only on starved applications would 
> avoid this situation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to