[
https://issues.apache.org/jira/browse/YARN-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883817#comment-15883817
]
Subru Krishnan commented on YARN-5602:
--------------------------------------
[~giovanni.fumarola], thanks for the patch. I looked at it and have a few minor
comments:
* I think you missed adding a comment on why _Capability_ and _HeartBeat_ are
not used for comparison as suggested by [~jianhe].
* I don't think we should not have HikariCP dependency in the utils.
Shouldn't that be part of the specific implementation?
* I feel that the {{FederationStateStoreErrorCode}} should correspond to the
API, as now multiple invocation failures that return the same error code?
* Nit: There are few public methods which don't have Javadocs.
> Utils for Federation State and Policy Store
> -------------------------------------------
>
> Key: YARN-5602
> URL: https://issues.apache.org/jira/browse/YARN-5602
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Giovanni Matteo Fumarola
> Assignee: Giovanni Matteo Fumarola
> Labels: oct16-medium
> Attachments: YARN-5602-YARN-2915.v1.patch,
> YARN-5602-YARN-2915.v2.patch, YARN-5602-YARN-2915.v3.patch,
> YARN-5602-YARN-2915.v4.patch
>
>
> This JIRA tracks the creation of utils for Federation State and Policy Store
> such as Error Codes, Exceptions...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
