[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888630#comment-15888630 ]
Sangjin Lee commented on YARN-6027: ----------------------------------- OK how about this? The {{TimelineUIDConverter}} class also uses these characters (the same ones). Can we at least standardize on one set of definitions? With this patch we would have {{TimelineUIDConverter#UID_DELIMETER_CHAR}} and {{TimelineUIDConverter#UID_ESCAPE_CHAR}}, and {{TimelineReaderUtils#DEFAULT_DELIMETER_CHAR}} and {{TimelineReaderUtils#DEFAULT_ESCAPE_CHAR}}. Specifically my proposal is to change the existing calls by {{TimelineUIDConverter}} to use the new constants in {{TimelineReaderUtils}} (or simply call {{split(String)}}). > Support fromid(offset) filter for /flows API > -------------------------------------------- > > Key: YARN-6027 > URL: https://issues.apache.org/jira/browse/YARN-6027 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Labels: yarn-5355-merge-blocker > Attachments: YARN-6027-YARN-5355.0001.patch, > YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch, > YARN-6027-YARN-5355.0004.patch, YARN-6027-YARN-5355.0005.patch, > YARN-6027-YARN-5355.0006.patch > > > In YARN-5585 , fromId is supported for retrieving entities. We need similar > filter for flows/flowRun apps and flow run and flow as well. > Along with supporting fromId, this JIRA should also discuss following points > * Should we throw an exception for entities/entity retrieval if duplicates > found? > * TimelieEntity : > ** Should equals method also check for idPrefix? > ** Does idPrefix is part of identifiers? -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org