[ https://issues.apache.org/jira/browse/YARN-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903855#comment-15903855 ]
Karthik Kambatla commented on YARN-6264: ---------------------------------------- Thanks for following up on this [~yufeigu]. Comments on the patch: # Let us add a comment in FSLeafQueue for why we are using the round-up version instead of the regular one. # There is a round-down version of the multiply which is the same as the regular one. Can we file a follow-up JIRA to get rid of it? # In the tests, can we use assertEquals and add a message for each assert? > AM not launched when a single vcore is available on the cluster > --------------------------------------------------------------- > > Key: YARN-6264 > URL: https://issues.apache.org/jira/browse/YARN-6264 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6264.001.patch, YARN-6264.002.patch, > YARN-6264.003.patch > > > In method {{canRunAppAM()}}, we should use policy related resource comparison > instead of using {{Resources.fitsIn()}} to determined if the queue has enough > resource for the AM. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org