[
https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jian He updated YARN-6342:
--------------------------
Description:
Found these with [~rohithsharma] while browsing the code
- In stop: it calls shutdownNow which doens't wait for pending tasks, should it
use shutdown instead ?
{code}
public void stop() {
LOG.info("Stopping TimelineClient.");
executor.shutdownNow();
try {
executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
{code}
- In TimelineClientImpl#createRunnable:
If any exception happens when publish one entity
(publishWithoutBlockingOnQueue), the thread exists. I think it should try best
effort to continue publishing the timeline entities, one failure should not
cause all followup entities not published.
was:
Found these with [~rohithsharma] while browsing the code
- In stop: it calls shutdownNow which doens't wait for pending tasks, should it
use shutdown instead ?
{code}
public void stop() {
LOG.info("Stopping TimelineClient.");
executor.shutdownNow();
try {
executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
{code}
- In TimelineClientImpl#createRunnable:
If any exception happens when publish one entity (ServiceTimelineEvent), the
thread exists. I think it should try best effort to continue publishing the
timeline entities, one failure should not cause all followup entities not
published.
> Issues in async API of TimelineClient
> -------------------------------------
>
> Key: YARN-6342
> URL: https://issues.apache.org/jira/browse/YARN-6342
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jian He
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should
> it use shutdown instead ?
> {code}
> public void stop() {
> LOG.info("Stopping TimelineClient.");
> executor.shutdownNow();
> try {
> executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
> } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity
> (publishWithoutBlockingOnQueue), the thread exists. I think it should try
> best effort to continue publishing the timeline entities, one failure should
> not cause all followup entities not published.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
