[ https://issues.apache.org/jira/browse/YARN-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932279#comment-15932279 ]
Hadoop QA commented on YARN-6255: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 53s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 31s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 47s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 42s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 30s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 16s{color} | {color:green} yarn-native-services passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} yarn-native-services passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 31s{color} | {color:red} hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications generated 9 new + 20 unchanged - 14 fixed = 29 total (was 34) {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 39s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications: The patch generated 172 new + 1568 unchanged - 594 fixed = 1740 total (was 2162) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 55s{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 36s{color} | {color:green} hadoop-yarn-slider-core in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 14s{color} | {color:green} hadoop-yarn-services-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 59s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core | | | Redundant nullcheck of template, which is known to be non-null in org.apache.slider.client.SliderClient.actionUpgrade(String, ActionUpgradeArgs) Redundant null check at SliderClient.java:is known to be non-null in org.apache.slider.client.SliderClient.actionUpgrade(String, ActionUpgradeArgs) Redundant null check at SliderClient.java:[line 951] | | | Redundant nullcheck of resources, which is known to be non-null in org.apache.slider.client.SliderClient.actionUpgrade(String, ActionUpgradeArgs) Redundant null check at SliderClient.java:is known to be non-null in org.apache.slider.client.SliderClient.actionUpgrade(String, ActionUpgradeArgs) Redundant null check at SliderClient.java:[line 947] | | | Dead store to amWebURI in org.apache.slider.server.appmaster.SliderAppMaster.registerServiceInstance(String, ApplicationId, Application) At SliderAppMaster.java:org.apache.slider.server.appmaster.SliderAppMaster.registerServiceInstance(String, ApplicationId, Application) At SliderAppMaster.java:[line 1094] | | | Dead store to role in org.apache.slider.server.appmaster.state.AppState.containerReleaseSubmitted(Container) At AppState.java:org.apache.slider.server.appmaster.state.AppState.containerReleaseSubmitted(Container) At AppState.java:[line 815] | | | Dead store to roleStatus in org.apache.slider.server.appmaster.state.AppState.innerOnNodeManagerContainerStarted(ContainerId) At AppState.java:org.apache.slider.server.appmaster.state.AppState.innerOnNodeManagerContainerStarted(ContainerId) At AppState.java:[line 1016] | | | Unread public/protected field:At AppStateBindingInfo.java:[line 47] | | | Class org.apache.slider.server.appmaster.state.RoleStatus implements Cloneable but does not define or use clone method At RoleStatus.java:does not define or use clone method At RoleStatus.java:[lines 62-341] | | | Dead store to roleStatusMap in org.apache.slider.server.appmaster.web.rest.application.resources.LiveResourcesRefresher.refresh() At LiveResourcesRefresher.java:org.apache.slider.server.appmaster.web.rest.application.resources.LiveResourcesRefresher.refresh() At LiveResourcesRefresher.java:[line 43] | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | YARN-6255 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12859506/YARN-6255.yarn-native-services.03.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml | | uname | Linux 03a53209463e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | yarn-native-services / 39ef50c | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | javac | https://builds.apache.org/job/PreCommit-YARN-Build/15329/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications.txt | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/15329/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications.txt | | findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/15329/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.html | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/15329/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/15329/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Refactor yarn-native-services framework > ---------------------------------------- > > Key: YARN-6255 > URL: https://issues.apache.org/jira/browse/YARN-6255 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Jian He > Assignee: Jian He > Attachments: YARN-6255.yarn-native-services.01.patch, > YARN-6255.yarn-native-services.02.patch, > YARN-6255.yarn-native-services.03.patch > > > YARN-4692 provides a good abstraction of services on YARN. We could use this > as a building block in yarn-native-services framework code base as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org