[ https://issues.apache.org/jira/browse/YARN-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935813#comment-15935813 ]
Sunil G commented on YARN-6164: ------------------------------- Few comments: In {{QueueConfigurations}} 1. All api's could be *Unstable* since its a fresh set of apis 2. All setters could be placed on {{QueueConfigurationsPBImpl}}. We need not have to place in QueueConfigurations. QueueConfigurationsProto.proto 3. I am not very sure whether we need to put all params as *required*. Its better to keep them as optional. 4. In {{QueueConfigurationsMapProto}}, nodeLabel could be renamed as partitionName. 5. Some more test cases from client side to see whether we are able to pull this data cleanly. You could add them in {{TestClientRMService}} or {{TestResourceMgrDelegate}} > Expose maximum-am-resource-percent in YarnClient > ------------------------------------------------ > > Key: YARN-6164 > URL: https://issues.apache.org/jira/browse/YARN-6164 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.7.2 > Reporter: Benson Qiu > Assignee: Benson Qiu > Attachments: YARN-6164.001.patch, YARN-6164.002.patch, > YARN-6164.003.patch, YARN-6164.004.patch, YARN-6164.005.patch, > YARN-6164.006.patch > > > `yarn.scheduler.capacity.maximum-am-resource-percent` is exposed through the > [Cluster Scheduler > API|http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API], > but not through > [YarnClient|https://hadoop.apache.org/docs/current/api/org/apache/hadoop/yarn/client/api/YarnClient.html]. > Since YarnClient and RM REST APIs depend on different ports (8032 vs 8088 by > default), it would be nice to expose `maximum-am-resource-percent` in > YarnClient as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org