[ https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941430#comment-15941430 ]
ASF GitHub Bot commented on YARN-5829: -------------------------------------- Github user kambatla commented on a diff in the pull request: https://github.com/apache/hadoop/pull/201#discussion_r108023020 --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java --- @@ -110,16 +149,57 @@ synchronized FSAppAttempt getReservedAppSchedulable() { } /** + * List reserved resources after preemption and assign them to the + * appropriate applications in a FIFO order. + * It is a good practice to call {@link #cleanupPreemptionList()} + * after this call + * @return if any resources were allocated + */ + synchronized LinkedHashMap<FSAppAttempt, Resource> getPreemptionList() { + cleanupPreemptionList(); + return new LinkedHashMap<>(resourcesPreemptedForApp); + } + + /** + * Remove apps that have their preemption requests fulfilled + */ + synchronized void cleanupPreemptionList() { + Iterator<FSAppAttempt> iterator = + resourcesPreemptedForApp.keySet().iterator(); + while (iterator.hasNext()) { + FSAppAttempt app = iterator.next(); + boolean removeApp = false; --- End diff -- This variable is not used. > FS preemption should reserve a node before considering containers on it for > preemption > -------------------------------------------------------------------------------------- > > Key: YARN-5829 > URL: https://issues.apache.org/jira/browse/YARN-5829 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Reporter: Karthik Kambatla > Assignee: Miklos Szegedi > > FS preemption evaluates nodes for preemption, and subsequently preempts > identified containers. If this node is not reserved for a specific > application, any other application could be allocated resources on this node. > Reserving the node for the starved application before preempting containers > would help avoid this. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org