[ 
https://issues.apache.org/jira/browse/YARN-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952050#comment-15952050
 ] 

Vrushali C commented on YARN-6425:
----------------------------------

Where do you think is a good place to put the dump call? In the 
UpdateThread#run after the fsOpDurations.addUpdateThreadRunDuration(duration)  
?  (looking at trunk code). 

> Move out FS state dump code out of method update()
> --------------------------------------------------
>
>                 Key: YARN-6425
>                 URL: https://issues.apache.org/jira/browse/YARN-6425
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>              Labels: newbie++
>
> Better to move out FS state dump code out of update()
> {code}
> if (LOG.isDebugEnabled()) {
>   if (--updatesToSkipForDebug < 0) {
>     updatesToSkipForDebug = UPDATE_DEBUG_FREQUENCY;
>     dumpSchedulerState();
>   }
> }
> {code}
> And, after that we should distinct between update call and update thread 
> duration like before YARN-6112. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to