[ https://issues.apache.org/jira/browse/YARN-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957363#comment-15957363 ]
Daniel Templeton commented on YARN-6381: ---------------------------------------- LGTM +1 I'll commit in a bit. > FSAppAttempt has several variables that should be final > ------------------------------------------------------- > > Key: YARN-6381 > URL: https://issues.apache.org/jira/browse/YARN-6381 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.0.0-alpha2 > Reporter: Daniel Templeton > Assignee: Ameet Zaveri > Labels: newbie > Attachments: YARN-6381.001.patch > > > These should all be final: > {code} > private long startTime; > private Priority appPriority; > private ResourceWeights resourceWeights; > private FairScheduler scheduler; > private Map<String, Set<String>> reservations = new HashMap<>(); > private List<FSSchedulerNode> blacklistNodeIds = new ArrayList<>(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org