[ https://issues.apache.org/jira/browse/YARN-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957431#comment-15957431 ]
Giovanni Matteo Fumarola commented on YARN-5602: ------------------------------------------------ Thanks [~subru] for reviewing the patch. About your comments: 1) I added a comment on why Capability and HeartBeat are not used for comparison. 2) I removed the HikariCP dependency. I will add it when we will add the FederationStateStore SQL implementation. 3) I edited the FederationStateStoreErrorCode to match with the APIs. 4) I added the missing javadocs. > Utils for Federation State and Policy Store > ------------------------------------------- > > Key: YARN-5602 > URL: https://issues.apache.org/jira/browse/YARN-5602 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Giovanni Matteo Fumarola > Assignee: Giovanni Matteo Fumarola > Labels: oct16-medium > Attachments: YARN-5602-YARN-2915.v1.patch, > YARN-5602-YARN-2915.v2.patch, YARN-5602-YARN-2915.v3.patch, > YARN-5602-YARN-2915.v4.patch, YARN-5602-YARN-2915.v5.patch, > YARN-5602-YARN-2915.v6.patch > > > This JIRA tracks the creation of utils for Federation State and Policy Store > such as Error Codes, Exceptions... -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org