[ 
https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957488#comment-15957488
 ] 

Miklos Szegedi commented on YARN-6438:
--------------------------------------

Thank you, [~yufeigu].

> Code can be improved in ContainersMonitorImpl.java
> --------------------------------------------------
>
>                 Key: YARN-6438
>                 URL: https://issues.apache.org/jira/browse/YARN-6438
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6438.000.patch, YARN-6438.001.patch, 
> YARN-6438.002.patch
>
>
> I noticed two code blocks that can be improved in ContainersMonitorImpl.java. 
>  cpuUsagePercentPerCoreByAllContainers and cpuUsageTotalCoresByAllContainers 
> track the same value and CHANGE_MONITORING_CONTAINER_RESOURCE is checked 
> twice along with two calls to changeContainerResource.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to