[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963632#comment-15963632
]
Daniel Templeton commented on YARN-5301:
----------------------------------------
{quote}I checked and we only iterate through these items later, when we add
them to the mount point. My understanding is that Set helps, when we search for
the items, so they need to be indexed at the expense of some memory. That is
not the case here. On the other hand, I can change it if you insist. I kept it
for now.{quote}
I was thinking more about making sure we don't get the same path in the list
more than once. Since the user is allowed input, there's no telling what
silliness they'll perpetrate.
{quote}Unfortunately, none of these options build to me. addAll requires T...
CGroupController.values() is CGroupController[], not compatible with
String[].{quote}
Good point. I missed the {{String}} v/s {{CGroupController}} thing. This is
where python list comprehensions would come in. :)
Regarding the {{UnsupportedOperationException}}, then use:
{code} List<String> cgroupList = new
LinkedList<>(Arrays.asList(options.split(",")));
// Collect the valid subsystem names
cgroupList.retain(validCgroups);{code}
About the exception in the finally, why in the finally there? Is it to close
the writer? If so, can you covert it to a _try-with-resources_ instead?
> NM mount cpu cgroups failed on some systems
> -------------------------------------------
>
> Key: YARN-5301
> URL: https://issues.apache.org/jira/browse/YARN-5301
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: sandflee
> Assignee: Miklos Szegedi
> Attachments: YARN-5301.000.patch, YARN-5301.001.patch,
> YARN-5301.002.patch
>
>
> on ubuntu with linux kernel 3.19, , NM start failed if enable auto mount
> cgroup. try command:
> ./bin/container-executor --mount-cgroups yarn-hadoop cpu=/cgroup/cpu fail
> ./bin/container-executor --mount-cgroups yarn-hadoop cpu,cpuacct=/cgroup/cpu
> succ
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
