[
https://issues.apache.org/jira/browse/YARN-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979848#comment-15979848
]
Soumabrata Chakraborty edited comment on YARN-6475 at 4/23/17 3:17 PM:
-----------------------------------------------------------------------
Hi [~miklos.szeg...@cloudera.com]
I fixed the two method length related issues as described on this JIRA.
Before I raise a PR, just wanted to check with you on the following:
There are 12 other violations related to method length in the project
hadoop-yarn-server-nodemanager.
Should I be addressing them too in this JIRA? Or should those be addressed
separately as part of a new JIRA?
was (Author: soumabrata):
[~miklos.szeg...@cloudera.com] Fixed the two method length related issues as
described on this JIRA.
Before I raise a PR, just wanted to check with you on the following:
There are 12 other violations related to method length in the project
hadoop-yarn-server-nodemanager.
Should I be addressing them too in this JIRA? Or should those be addressed
separately as part of a new JIRA?
> Fix some long function checkstyle issues
> ----------------------------------------
>
> Key: YARN-6475
> URL: https://issues.apache.org/jira/browse/YARN-6475
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Miklos Szegedi
> Assignee: Soumabrata Chakraborty
> Priority: Trivial
> Labels: newbie
>
> I am talking about these two:
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:441:
> @Override:3: Method length is 176 lines (max allowed is 150). [MethodLength]
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:159:
> @Override:3: Method length is 158 lines (max allowed is 150). [MethodLength]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
