[ 
https://issues.apache.org/jira/browse/YARN-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984893#comment-15984893
 ] 

Sunil G commented on YARN-6419:
-------------------------------

Thanks [~akhilpb] for the patch and screen shots. Looks good.

Few comments
# Could jqueryAjax be moved to AbstractAdapter class if this is reusable?
# Is config-tooltip.js used still?
# Rename config-upload-modal.js to upload-config.js
# deploy-service.hbs and service-config-table.hbs needs some more refactoring 
may be?
# are we using yarn-services.hbs still ? If not, please remove.

> Support to launch native-service deployment from new YARN UI
> ------------------------------------------------------------
>
>                 Key: YARN-6419
>                 URL: https://issues.apache.org/jira/browse/YARN-6419
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-ui-v2
>            Reporter: Akhil PB
>            Assignee: Akhil PB
>         Attachments: Screenshot-deploy-new-service-form-input.png, 
> Screenshot-deploy-new-service-json-input.png, 
> Screenshot-deploy-service-add-component-form-input.png, YARN-6419.001.patch, 
> YARN-6419.002.patch, YARN-6419.003.patch, YARN-6419.004.patch, 
> YARN-6419-yarn-native-services.001.patch, 
> YARN-6419-yarn-native-services.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to