[
https://issues.apache.org/jira/browse/YARN-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985180#comment-15985180
]
ASF GitHub Bot commented on YARN-6475:
--------------------------------------
GitHub user soumabrata-chakraborty opened a pull request:
https://github.com/apache/hadoop/pull/218
YARN-6475: Refactor long methods in hadoop-yarn-server-nodemanager
Refactor all methods in hadoop-yarn-server-nodemanager that exceed 150
lines in length. Also fixes the method length related Checkstyle violations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soumabrata-chakraborty/hadoop YARN-6475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit b2a01a19676d8fa70b6dc906f453c8ddd950bddf
Author: Soumabrata Chakraborty <soumabr...@gmail.com>
Date: 2017-04-25T18:26:29Z
Refactor code for methods above 150 lines in length
commit 4621373c878307e7f0a223638501cdd43c9358dd
Author: Soumabrata Chakraborty <soumabr...@gmail.com>
Date: 2017-04-26T17:03:41Z
Refactor code for methods above 150 lines in length
----
> Fix some long function checkstyle issues
> ----------------------------------------
>
> Key: YARN-6475
> URL: https://issues.apache.org/jira/browse/YARN-6475
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Miklos Szegedi
> Assignee: Soumabrata Chakraborty
> Priority: Trivial
> Labels: newbie
>
> I am talking about these two:
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:441:
> @Override:3: Method length is 176 lines (max allowed is 150). [MethodLength]
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:159:
> @Override:3: Method length is 158 lines (max allowed is 150). [MethodLength]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
