[ 
https://issues.apache.org/jira/browse/YARN-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991145#comment-15991145
 ] 

Manikandan R commented on YARN-6467:
------------------------------------

[~Naganarasimha]

Modified almost all related methods in QueueMetrics.java & CSQueueMetrics.java 
to accept new "label" parameter and made changes in all required places to pass 
the same param as part of calling those methods. Few methods has been 
overloaded to provide backward compatibility for FairScheduler.java & 
FIFOScheduler.java (for ex, reserverResource() in QueueMetrics.java).

Reg junits, currently am passing "default" label as hardcoded value in some 
places (for ex, TestQueueMetrics.java). Ideally, it can be enhanced to cover 
test cases for non default partitions as well once we start implementing label 
based metrics. Otherwise, passing proper values dynamically.

> CSQueueMetrics needs to update the current metrics for default partition only
> -----------------------------------------------------------------------------
>
>                 Key: YARN-6467
>                 URL: https://issues.apache.org/jira/browse/YARN-6467
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 2.8.0, 2.7.3, 3.0.0-alpha2
>            Reporter: Naganarasimha G R
>            Assignee: Manikandan R
>         Attachments: YARN-6467.001.patch, YARN-6467.001.patch
>
>
> As a followup to YARN-6195, we need to update existing metrics to only 
> default Partition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to