[ https://issues.apache.org/jira/browse/YARN-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994097#comment-15994097 ]
Yufei Gu edited comment on YARN-6522 at 5/3/17 12:28 AM: --------------------------------------------------------- Thanks [~rkanter] for the review. Uploaded patch v2 which does followups: 1. Add static constant for mapper/reduce priority. 2. Add back {{job.finish.ms}} 3. Change to {{num.nodes}} and {{num.racks}}, add unit tests. The function {{generateNodes}} is used by SYN input format originally and flaw. Fix the issue in it. 4. Add documentation 5. {{jsonJob.get("job.id").toString()}} throws a NPE if there is no {{job.id}}. was (Author: yufeigu): Thanks [~rkanter] for the review. Uploaded patch v2. 1. Add static constant for mapper/reduce priority. 2. Add back {{job.finish.ms}} 3. Change to {{num.nodes}} and {{num.racks}}, add unit tests. The function {{generateNodes}} is used by SYN input format originally and flaw. Fix the issue in it. 4. Add documentation 5. {{jsonJob.get("job.id").toString()}} throws a NPE if there is no {{job.id}}. > Make SLS JSON input file format simple and scalable > --------------------------------------------------- > > Key: YARN-6522 > URL: https://issues.apache.org/jira/browse/YARN-6522 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler-load-simulator > Affects Versions: 3.0.0-alpha2 > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6522.001.patch, YARN-6522.002.patch > > > SLS input format is verbose, and it doesn't scale out. We can improve it in > these ways: > # We need to configure tasks one by one if there are more than one task in a > job, which means the job configuration usually includes lots of redundant > items. To specify the number of task for task configuration will solve this > issue. > # Container host is useful for locality testing. It is obnoxious to specify > container host for each task for tests unrelated to locality. We would like > to make it optional. > # For most tests, we don't care about job.id. Make it optional and generated > automatically by default. > # job.finish.ms doesn't make sense, just remove it. > # container type and container priority should be optional as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org