[
https://issues.apache.org/jira/browse/YARN-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998977#comment-15998977
]
Wangda Tan commented on YARN-6560:
----------------------------------
[~yufeigu],
Thanks for the review.
For 1), because we could use SLSRunner without calling main() for unit tests.
So {{setConf}} inside ToolRunner is actually unnecessary.
For 2), Updated.
Uploaded ver.2 patch.
> SLS doesn't honor node total resource specified in sls-runner.xml
> -----------------------------------------------------------------
>
> Key: YARN-6560
> URL: https://issues.apache.org/jira/browse/YARN-6560
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6560.1.patch
>
>
> Now SLSRunner extends ToolRunner, so setConf will be called twice: once in
> the init() of SLSRunner and once in ToolRunner. The later one will overwrite
> the previous one so it won't correctly load sls-runner.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
