[ https://issues.apache.org/jira/browse/YARN-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007199#comment-16007199 ]
Hudson commented on YARN-5543: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11725 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11725/]) YARN-5543. ResourceManager SchedulingMonitor could potentially terminate (shv: rev 2ada100da7cfe12946e43da2929bd80c2a8bd833) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/TestSchedulingMonitor.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/SchedulingMonitor.java > ResourceManager SchedulingMonitor could potentially terminate the preemption > checker thread > ------------------------------------------------------------------------------------------- > > Key: YARN-5543 > URL: https://issues.apache.org/jira/browse/YARN-5543 > Project: Hadoop YARN > Issue Type: Bug > Components: capacityscheduler, resourcemanager > Affects Versions: 2.7.0, 2.6.1 > Reporter: Min Shen > Assignee: Min Shen > Labels: oct16-medium > Fix For: 2.9.0, 2.7.4, 3.0.0-alpha3, 2.8.2 > > Attachments: YARN-5543.001.patch, YARN-5543.002.patch, > YARN-5543.003.patch, YARN-5543.004.patch, YARN-5543-branch-2.7.001.patch, > YARN-5543-branch-2.7.002.patch > > > In SchedulingMonitor.java, when the service starts, it starts a checker > thread to perform Capacity Scheduler's preemption. However, the > implementation of this checker thread has the following issue: > {code} > while (!stopped && !Thread.currentThread().isInterrupted()) { > .... > try { > Thread.sleep(monitorInterval) > } catch (InterruptedException e) { > .... > break; > } > } > {code} > The above code snippet will terminate the checker thread whenever it is > interrupted. > We noticed in our cluster that this could lead to CapacityScheduler's > preemption disabled unexpectedly due to the checker thread getting terminated. > We propose to use ScheduledExecutorService to improve the robustness of this > part of the code to ensure the liveness of CapacityScheduler's preemption > functionality. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org