[
https://issues.apache.org/jira/browse/YARN-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015209#comment-16015209
]
Wangda Tan commented on YARN-6593:
----------------------------------
Thanks [~kkaranasos],
bq. Self-reference works fine even with the current protobuf version. I think I
saw a single use of it in our yarn_protos (I think it was in the QueueInfo or
something related).
Sounds good, thanks for confirmation.
bq. (1) the proto becomes too complicated (and I am afraid we will be the only
ones understanding it
This statement is true. :)
bq. (2) the client will still have access to very unrelated getters and setters.
This part is avoidable, we can avoid add un-related getters and setters to Java
API class, and access PB methods in -PBImpl class.
For example:
{code}
class TargetConstraint {
// Only expose what required
get/setTargetExpression();
get/setScope();
}
class TargetConstraintPBImpl implements TargetConstraint {
void setTargetExpression(...) {
// Access fields in Proto in -PBImpl only
SimplePlacementConstraintProtoBuilder.setTargetExpression(..);
}
}
{code}
Please let me know what you think.
> [API] Introduce Placement Constraint object
> -------------------------------------------
>
> Key: YARN-6593
> URL: https://issues.apache.org/jira/browse/YARN-6593
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Attachments: YARN-6593.001.patch
>
>
> This JIRA introduces an object for defining placement constraints.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
