[ https://issues.apache.org/jira/browse/YARN-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020319#comment-16020319 ]
Robert Kanter edited comment on YARN-6625 at 5/22/17 10:21 PM: --------------------------------------------------------------- Overall looks good. Here's some comments: # In {{ClientRMProxy}}, instead of {{return new Text(schedulerService + "," + adminService);}}, let's use {{Joiner}} like what's used below it in {{getTokenService}}. # {{ClientRMProxy#getAMRMTokenService}} is used in a few places. Have you made sure that they're all okay with adding the RM admin address? # I'm not expert on the way our RPCs work, but is {{HAServiceProtocolPB}} the right thing to check in {{AdminSecurityInfo}}? Just from the name, it seems funny to use an "HA" Protocol here because what happens in a non-HA cluster? In any case, based on the {{getKerberosInfo}} above it and the name itself, wouldn't {{ResourceManagerAdministrationProtocolPB}} be the right thing to use? # It would also be good to add some kind of test, though that might be tricky was (Author: rkanter): Overall looks good. Here's some comments: # In {{ClientRMProxy}}, instead of {{return new Text(schedulerService + "," + adminService);}}, let's use {{Joiner}} like what's used below it in {{getTokenService}}. # {{ClientRMProxy#getAMRMTokenService}} is used in a few places. Have you made sure that they're all okay with adding the RM admin address? # I'm not expert on the way our RPCs work, but is {{HAServiceProtocolPB}} the right thing to check in {{AdminSecurityInfo}}? Just from the name, it seems funny to use an "HA" Protocol here because what happens in a non-HA cluster? In any case, based on the {{getKerberosInfo}} above it and the name itself, wouldn't {{ResourceManagerAdministrationProtocolPB}} be the right thing to use? > yarn application -list returns a tracking URL for AM that doesn't work in > secured and HA environment > ---------------------------------------------------------------------------------------------------- > > Key: YARN-6625 > URL: https://issues.apache.org/jira/browse/YARN-6625 > Project: Hadoop YARN > Issue Type: Bug > Components: amrmproxy > Affects Versions: 3.0.0-alpha2 > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6625.001.patch > > > The tracking URL given at the command line should work secured or not. The > tracking URLs are like http://node-2.abc.com:47014 and AM web server supposed > to redirect it to a RM address like this > http://node-1.abc.com:8088/proxy/application_1494544954891_0002/, but it > fails to do that because the connection is rejected when AM is talking to RM > admin service to get HA status. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org