[
https://issues.apache.org/jira/browse/YARN-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035208#comment-16035208
]
Sunil G commented on YARN-6585:
-------------------------------
HI [~eepayne]
Thanks for the comments.
In similar to {{GetClusterNodeLabelsResponse}}, it was also support labels as
string earlier. then its moved to list of NodeLabel. Ideally
{{initLocalNodeLabels}} helps to cover the case.
In my test case, i was making sure that we have stored labels as string (like
in 2.7 version), then read it back to ensure labels are still loaded an
readable from RM. Ideally we need not have to have mirror file specific case.
Labels as string to be addd to cluster, and read it back in current form (as
list of NodeLabel) to ensure all labels are added with exclusivity on. Hence i
needed setter and getter. All cases were same in
{{GetClusterNodeLabelsResponse}} and its PBImpl also.
Pls share your thoughts.
> RM fails to start when upgrading from 2.7 to 2.8 for clusters with node
> labels.
> -------------------------------------------------------------------------------
>
> Key: YARN-6585
> URL: https://issues.apache.org/jira/browse/YARN-6585
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Eric Payne
> Assignee: Sunil G
> Priority: Blocker
> Attachments: YARN-6585.0001.patch, YARN-6585.0002.patch
>
>
> {noformat}
> Caused by: java.io.IOException: Not all labels being replaced contained by
> known label collections, please check, new labels=[abc]
> at
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.checkReplaceLabelsOnNode(CommonNodeLabelsManager.java:718)
> at
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.replaceLabelsOnNode(CommonNodeLabelsManager.java:737)
> at
> org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager.replaceLabelsOnNode(RMNodeLabelsManager.java:189)
> at
> org.apache.hadoop.yarn.nodelabels.FileSystemNodeLabelsStore.loadFromMirror(FileSystemNodeLabelsStore.java:181)
> at
> org.apache.hadoop.yarn.nodelabels.FileSystemNodeLabelsStore.recover(FileSystemNodeLabelsStore.java:208)
> at
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.initNodeLabelStore(CommonNodeLabelsManager.java:251)
> at
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.serviceStart(CommonNodeLabelsManager.java:265)
> at
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> ... 13 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
