[
https://issues.apache.org/jira/browse/YARN-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035410#comment-16035410
]
Daniel Templeton commented on YARN-6679:
----------------------------------------
bq. Using signum to handle a NaN (impossible, I hope?) may not be worth the
cost.
I just have something against ternary operators. :) I'm OK with filing a
newbie JIRA to swap it out.
bq. I'd say very.
I was hoping you'd say that.
Regarding tests, yeah, the functionality is likely covered by existing tests,
but indirectly. Tracking down the issue if it pops up in another test is
nowhere near as straightforward as if it's caught by a bespoke test. In this
case, I don't think we need much. The {{newInstance()}} methods changed, and
the util method to get the proto changed. That's 3 tests and should be a
really small effort. If you don't want to humor me, though, we can let it
slide. This time. [queue: dramatic music]
> Reduce Resource instance overhead via non-PBImpl
> ------------------------------------------------
>
> Key: YARN-6679
> URL: https://issues.apache.org/jira/browse/YARN-6679
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-6679.branch-2.patch, YARN-6679.trunk.patch
>
>
> Creating and using transient PB-based Resource instances during scheduling is
> very expensive. The overhead can be transparently reduced by internally
> using lightweight non-PB based instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
