[
https://issues.apache.org/jira/browse/YARN-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043852#comment-16043852
]
Naganarasimha G R commented on YARN-6681:
-----------------------------------------
hi [~daryn], mostly looks good to me, but is it not good enough that leaf
queue returns false and parent queue returns true ?
Is there any scenario where we need to do this check ?
> Eliminate double-copy of child queues in canAssignToThisQueue
> -------------------------------------------------------------
>
> Key: YARN-6681
> URL: https://issues.apache.org/jira/browse/YARN-6681
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-6681.2.branch-2.8.patch,
> YARN-6681.2.branch-2.patch, YARN-6681.2.trunk.patch,
> YARN-6681.branch-2.8.patch, YARN-6681.branch-2.patch, YARN-6681.trunk.patch
>
>
> 20% of the time in {{AbstractCSQueue#canAssignToThisQueue}} is spent
> performing two duplications a treemap of child queues into a list - once to
> test for null, second to see if it's empty. Eliminating the dups reduces the
> overhead to 2%.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
