[ https://issues.apache.org/jira/browse/YARN-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061722#comment-16061722 ]
Subru Krishnan edited comment on YARN-3659 at 6/24/17 2:02 AM: --------------------------------------------------------------- Thanks [~giovanni.fumarola] for addressing my feedback. The latest patch LGTM (pending Yetus), have a couple of nits: * *setupUser* can be done before initializing the next interceptor in {{AbstractClientRequestInterceptor}}. * A few comments on {{FederationClientInterceptor::submitApplication}}: ** Avoid the continues by switching the checks, i.e. return _response_ if not null, otherwise log warn followed by completion of loop iteration. ** We should throw exception instead of returning nulls to be consistent with *ClientRMService*. ** Fix the log statements based on the above changes. was (Author: subru): Thanks [~giovanni.fumarola] for addressing my feedback. The latest patch LGTM, have a couple of nits: * *setupUser* can be done before initializing the next interceptor in {{AbstractClientRequestInterceptor}}. * A few comments on the logging in {{FederationClientInterceptor::submitApplication}}: ** The log statement for submitted should be after the null check for _response_. ** The log statement for app submitted exception and null _response_ can be warn as we don't exit but continue with another subcluster. > Federation Router (hiding multiple RMs for ApplicationClientProtocol) > --------------------------------------------------------------------- > > Key: YARN-3659 > URL: https://issues.apache.org/jira/browse/YARN-3659 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client, resourcemanager > Reporter: Giovanni Matteo Fumarola > Assignee: Giovanni Matteo Fumarola > Attachments: YARN-3659.pdf, YARN-3659-YARN-2915.1.patch, > YARN-3659-YARN-2915.2.patch, YARN-3659-YARN-2915.draft.patch > > > This JIRA tracks the design/implementation of the layer for routing > ApplicaitonClientProtocol requests to the appropriate > RM(s) in a federated YARN cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org