[
https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094257#comment-16094257
]
Rohith Sharma K S commented on YARN-6130:
-----------------------------------------
[~varun_saxena] I skimmed through the patch. First look comments are below
# for every heartbeat, we are creating AMCollectorInfo object. Could it be
cached?
# newly added proto i.e AMCollectorInfoProto has rm_identifier and version. Why
does these required for AM? IAC, collector_address and token can be kept in
separate proto may be name it as generic i.e CollectorInfo or any other?
# I see AppCollectorData#hasSameVersion added. Where it will be used? Trying to
understanding its usage
> [ATSv2 Security] Generate a delegation token for AM when app collector is
> created and pass it to AM via NM and RM
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6130
> URL: https://issues.apache.org/jira/browse/YARN-6130
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6130-YARN-5355.01.patch,
> YARN-6130-YARN-5355.02.patch, YARN-6130-YARN-5355.03.patch,
> YARN-6130-YARN-5355.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
