[ 
https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096454#comment-16096454
 ] 

Sangjin Lee commented on YARN-6771:
-----------------------------------

Thanks for linking the ticket.

As for wider tests, I think it'd be great if you can run full YARN and 
mapreduce tests. If you have a working development environment, one could do
{code}
mvn clean install -DskipTests
cd hadoop-yarn-project/hadoop-yarn
mvn test -fn
cd ../../hadoop-mapreduce-project
mvn test -fn
{code}

Now, this is easier said than done. The reality is that this will take quite a 
while to run (around a couple of hours). And unfortunately I think there are 
some tests that are flaky or may fail depending on the environment. So this is 
not going to be exact science. The best effort is to run this on the current 
trunk, run it again with your patch, and see if there are "obvious" new 
failures that may be related to your patch. Let me know if that is something 
you can try. For setting up the dev environment, you can look at 
https://wiki.apache.org/hadoop/HowToSetupYourDevelopmentEnvironment.


> Use classloader inside configuration class to make new classes 
> ---------------------------------------------------------------
>
>                 Key: YARN-6771
>                 URL: https://issues.apache.org/jira/browse/YARN-6771
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.1, 3.0.0-alpha4
>            Reporter: Jongyoul Lee
>             Fix For: 2.8.2
>
>         Attachments: YARN-6771-1.patch, YARN-6771-2.patch, YARN-6771.patch
>
>
> While running {{RpcClientFactoryPBImpl.getClient}}, 
> {{RpcClientFactoryPBImpl}} uses {{localConf.getClassByName}}. But in case of 
> using custom classloader, we have to use {{conf.getClassByName}} because 
> custom classloader is already stored in {{Configuration}} class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to