[ 
https://issues.apache.org/jira/browse/YARN-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100795#comment-16100795
 ] 

Yufei Gu commented on YARN-6505:
--------------------------------

Thanks [~GergelyNovak] for working on this. Looks good to me generally. Some 
thoughts:
# Patch v1 doesn't apply to trunk anymore. Can you rebase it?
# YARN-6685 adds job count in to SLS JSON input format, can you add that as 
well?

> Define the strings used in SLS JSON input file format
> -----------------------------------------------------
>
>                 Key: YARN-6505
>                 URL: https://issues.apache.org/jira/browse/YARN-6505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler-load-simulator
>            Reporter: Yufei Gu
>            Assignee: Gergely Novák
>              Labels: newbie
>         Attachments: YARN-6505.001.patch
>
>
> We could put them in a Java file like what YarnConfiguration does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to