[ 
https://issues.apache.org/jira/browse/YARN-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107959#comment-16107959
 ] 

Carlo Curino commented on YARN-6853:
------------------------------------

[~giovanni.fumarola], thanks for the contribution. The patch looks fine, as it 
is rather similar to the SQLServer one, we reviewed before. A couple of small 
asks:
# In documentations, should we provide examples for both mysql and sql-server?
# The field {{params}} of table {{policies}} is set to be varbinary(512), I 
think it would be best to be longer, as the payload might be large in some 
cases (lots of subclusters, etc..).
# In documentations, call-out that the users are supposed to set their own 
proper passwords in {{FederationStateStoreUser.sql}}, or use proper user/pass 
setup. The script is comfy to include for testing, but we need to call out 
prominently that proper user/pass setup is required.


> Add MySql Scripts for FederationStateStore
> ------------------------------------------
>
>                 Key: YARN-6853
>                 URL: https://issues.apache.org/jira/browse/YARN-6853
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>         Attachments: YARN-6853.v1.patch, YARN-6853-YARN-2915.v1.patch, 
> YARN-6853-YARN-2915.v2.patch, YARN-6853-YARN-2915.v3.patch, 
> YARN-6853-YARN-2915.v4.patch
>
>
> In YARN-3663 we added the SQL scripts for SQLServer. We want to add the MySql 
> scripts to be able to run Federation with a MySQL servers which will be less 
> performant but convenient.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to