[ 
https://issues.apache.org/jira/browse/YARN-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109921#comment-16109921
 ] 

Arun Suresh edited comment on YARN-6593 at 8/1/17 10:38 PM:
------------------------------------------------------------

bq. Actually, my comments should apply to YARN-6594 rather this jira.
[~jianhe], I am guessing you are referring to the *AllocationTags* .. then yes, 
we should continue that discussion in YARN-6594, since this pertains just to 
the *PlacementConstraint* object. (Can you please cross-post it there as well 
?)  

My opinion though is that the allocation tags should remain a list of string 
keys. I understand having it as a map might offload some work from the AM, but 
do you see it helping the RM/scheduler in making a scheduling decision ? If it 
is just to select a bunch of containers, one can still perform a search like: 
select containers where allocationtags contains "env=test" etc. Forcing the 
tags to be a map might even make the querying more complicated.


was (Author: asuresh):
bq. Actually, my comments should apply to YARN-6594 rather this jira.
[~jianhe], I am guessing you are referring to the *AllocationTags* .. then yes, 
we should continue that discussion in YARN-6594, since this pertains just to 
the *PlacementConstraint* object. (Can you please cross-post it there as well 
?)  

My opinion though is that the allocation tags should remain a list of string 
keys. I understand this might offload some work from the AM, but do you see it 
helping the RM/scheduler in making a scheduling decision ? If it is just to 
select a bunch of containers, one can still perform a search like: select 
containers where allocationtags contains "env=test" etc. Forcing the tags to be 
a map might even make the querying more complicated.

> [API] Introduce Placement Constraint object
> -------------------------------------------
>
>                 Key: YARN-6593
>                 URL: https://issues.apache.org/jira/browse/YARN-6593
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-6593.001.patch, YARN-6593.002.patch, 
> YARN-6593.003.patch, YARN-6593.004.patch, YARN-6593.005.patch, 
> YARN-6593.006.patch, YARN-6593.007.patch, YARN-6593.008.patch
>
>
> Just removed Fixed version and moved it to target version as we set fix 
> version only after patch is committed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to