[ 
https://issues.apache.org/jira/browse/YARN-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110347#comment-16110347
 ] 

Sunil G commented on YARN-6741:
-------------------------------

Thanks [~naganarasimha...@apache.org].  
I understood the idea of minimizing operations by which one can modify queues 
and start working on same. And I think next point makes this more convenient. 
To delete any child queue, that leaf queue has to be stopped first. This covers 
any unwanted ops or issues. hence i think its fine to convert parent queue to 
leaf when all children are deleted(by stopping them first). Since that is 
covered, I have no objection in this current approach.

It will be great if one more test case is added or as part of existing case. 
Out of one child queue of b, let one queue be RUNNING. and lets try to 
reinitialize queue by deleting all 3. Exception will be thrown and we can 
validate same. Post that, we can push b3 to be STOPPED and do as current test 
case does.

> Deleting all children of a Parent Queue on refresh throws exception
> -------------------------------------------------------------------
>
>                 Key: YARN-6741
>                 URL: https://issues.apache.org/jira/browse/YARN-6741
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-6741.001.patch, YARN-6741.002.patch, 
> YARN-6741.003.patch
>
>
> If we configure CS such that all  children of a parent queue are deleted and 
> made as a leaf queue, then {{refreshQueue}} operation fails when 
> re-initializing the parent Queue
> {code}
>        // Sanity check
>       if (!(newlyParsedQueue instanceof ParentQueue) || !newlyParsedQueue
>           .getQueuePath().equals(getQueuePath())) {
>         throw new IOException(
>             "Trying to reinitialize " + getQueuePath() + " from "
>                 + newlyParsedQueue.getQueuePath());
>       }
> {code}
> *Expected Behavior:*
> Converting a Parent Queue to leafQueue on refreshQueue needs to be supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to