[
https://issues.apache.org/jira/browse/YARN-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118801#comment-16118801
]
Eric Badger commented on YARN-6930:
-----------------------------------
Hey [~shaneku...@gmail.com], thanks for the patch! I have a few comments
If we're only allowing certain runtimes to be executed, then shouldn't we not
even init them in {{DelegatingLinuxContainerRuntime.java:initialize()}}?
I think {{DEFAULT_LINUX_CONTAINER_RUNTIME_ALLOWED_RUNTIMES}} and
{{allowedRuntimes}} should be arrays of Strings. That way we can test equality
against the array elements instead of whether a long string contains a
substring.
Should we set {{runtime = null}} if the runtime isn't allowed, just in case
someone catches the {{ContainerExecutionException}} somewhere up the line?
> Admins should be able to explicitly enable specific LinuxContainerRuntime in
> the NodeManager
> --------------------------------------------------------------------------------------------
>
> Key: YARN-6930
> URL: https://issues.apache.org/jira/browse/YARN-6930
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Shane Kumpf
> Attachments: YARN-6930.001.patch
>
>
> Today, in the java land, all LinuxContainerRuntimes are always enabled when
> using LinuxContainerExecutor and the user can simply invoke anything that
> he/she wants - default, docker, java-sandbox.
> We should have a way for admins to explicitly enable only specific runtimes
> that he/she decides for the cluster. And by default, we should have
> everything other than the default one disabled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
